Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coverity issues in acl_program_test.cpp #271

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

IlanTruanovsky
Copy link
Contributor

A couple of function calls' return values where not being checked.

FIxes:

test/acl_program_test.cpp:133:3:
  Type: Unchecked return value (CHECKED_RETURN)

test/acl_program_test.cpp:133:3: Unchecked call to function
  1. check_return: Calling "acl_program_is_valid" without checking return value (as is done elsewhere 35 out of 36 times).
src/acl_kernel.cpp:2326:3: Examples where return value from this function is checked
  2. example_checked: Example 1: "acl_program_is_valid(kernel->program)" has its value checked in "acl_program_is_valid(kernel->program)".
src/acl_kernel.cpp:199:3: Examples where return value from this function is checked
  3. example_checked: Example 2: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_profiler.cpp:592:3: Examples where return value from this function is checked
  4. example_checked: Example 3: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_program.cpp:131:3: Examples where return value from this function is checked
  5. example_checked: Example 4: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_program.cpp:1463:3: Examples where return value from this function is checked
  6. example_checked: Example 5: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".

test/acl_program_test.cpp:132:3:
  Type: Unchecked return value (CHECKED_RETURN)

test/acl_program_test.cpp:132:3: Unchecked call to function
  1. check_return: Calling "acl_is_valid_ptr" without checking return value (as is done elsewhere 6 out of 7 times).
src/acl_program.cpp:1239:3: Examples where return value from this function is checked
  2. example_checked: Example 1: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:148:3: Examples where return value from this function is checked
  3. example_checked: Example 2: "acl_is_valid_ptr(cl_program const(NULL))" has its value checked in "acl_is_valid_ptr(cl_program const(NULL))".
test/acl_program_test.cpp:348:3: Examples where return value from this function is checked
  4. example_checked: Example 3: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:239:3: Examples where return value from this function is checked
  5. example_checked: Example 4: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:270:3: Examples where return value from this function is checked
  6. example_checked: Example 5: "acl_is_valid_ptr(cl_program const(&fake_program))" has its value checked in "acl_is_valid_ptr(cl_program const(&fake_program))".

@IlanTruanovsky IlanTruanovsky self-assigned this Feb 3, 2023
@IlanTruanovsky IlanTruanovsky added the bug Something isn't working label Feb 3, 2023
@IlanTruanovsky IlanTruanovsky added this to the 2023.2 milestone Feb 3, 2023
A couple of function calls' return values where not being checked.

FIxes:
```
test/acl_program_test.cpp:133:3:
  Type: Unchecked return value (CHECKED_RETURN)

test/acl_program_test.cpp:133:3: Unchecked call to function
  1. check_return: Calling "acl_program_is_valid" without checking return value (as is done elsewhere 35 out of 36 times).
src/acl_kernel.cpp:2326:3: Examples where return value from this function is checked
  2. example_checked: Example 1: "acl_program_is_valid(kernel->program)" has its value checked in "acl_program_is_valid(kernel->program)".
src/acl_kernel.cpp:199:3: Examples where return value from this function is checked
  3. example_checked: Example 2: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_profiler.cpp:592:3: Examples where return value from this function is checked
  4. example_checked: Example 3: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_program.cpp:131:3: Examples where return value from this function is checked
  5. example_checked: Example 4: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".
src/acl_program.cpp:1463:3: Examples where return value from this function is checked
  6. example_checked: Example 5: "acl_program_is_valid(program)" has its value checked in "acl_program_is_valid(program)".

test/acl_program_test.cpp:132:3:
  Type: Unchecked return value (CHECKED_RETURN)

test/acl_program_test.cpp:132:3: Unchecked call to function
  1. check_return: Calling "acl_is_valid_ptr" without checking return value (as is done elsewhere 6 out of 7 times).
src/acl_program.cpp:1239:3: Examples where return value from this function is checked
  2. example_checked: Example 1: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:148:3: Examples where return value from this function is checked
  3. example_checked: Example 2: "acl_is_valid_ptr(cl_program const(NULL))" has its value checked in "acl_is_valid_ptr(cl_program const(NULL))".
test/acl_program_test.cpp:348:3: Examples where return value from this function is checked
  4. example_checked: Example 3: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:239:3: Examples where return value from this function is checked
  5. example_checked: Example 4: "acl_is_valid_ptr(program)" has its value checked in "acl_is_valid_ptr(program)".
test/acl_program_test.cpp:270:3: Examples where return value from this function is checked
  6. example_checked: Example 5: "acl_is_valid_ptr(cl_program const(&fake_program))" has its value checked in "acl_is_valid_ptr(cl_program const(&fake_program))".
```
@pcolberg pcolberg merged commit 9bd8ee7 into intel:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants