Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PRINTF_ARGS Coverity issues #255

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix PRINTF_ARGS Coverity issues #255

merged 1 commit into from
Jan 27, 2023

Conversation

IlanTruanovsky
Copy link
Contributor

Fixes:

test/acl_device_test.cpp:350:7:
  Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)

test/acl_device_test.cpp:350:7:
  invalid_type: Argument "value" to format specifier "%8x" was expected to have type "unsigned int" but has type "unsigned long".
src/acl_hal.cpp:123:3:
  path: Condition "debug_mode > 0", taking true branch.
src/acl_hal.cpp:126:5:
  printf_function: Calling "vprintf" which uses a "printf"-style format string. [Note: The source code implementation of the function has been overridden by a builtin model.]

test/acl_device_test.cpp:360:7:
  Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)

test/acl_device_test.cpp:360:7:
  invalid_type: Argument "value" to format specifier "%8x" was expected to have type "unsigned int" but has type "unsigned long".
src/acl_hal.cpp:123:3:
  path: Condition "debug_mode > 0", taking true branch.
src/acl_hal.cpp:126:5:
  printf_function: Calling "vprintf" which uses a "printf"-style format string. [Note: The source code implementation of the function has been overridden by a builtin model.]

@IlanTruanovsky IlanTruanovsky self-assigned this Jan 26, 2023
@IlanTruanovsky IlanTruanovsky added the bug Something isn't working label Jan 26, 2023
@IlanTruanovsky IlanTruanovsky added this to the 2023.1 milestone Jan 26, 2023
pcolberg
pcolberg reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IlanTruanovsky. Could you also move c569883 into this PR?

@pcolberg pcolberg modified the milestones: 2023.1, 2023.2 Jan 26, 2023
@pcolberg pcolberg mentioned this pull request Jan 26, 2023
Merged
@IlanTruanovsky
Fix PRINTF_ARGS Coverity issues
167cf75 
Fixes:

```
test/acl_device_test.cpp:350:7:
  Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)

test/acl_device_test.cpp:350:7:
  invalid_type: Argument "value" to format specifier "%8x" was expected to have type "unsigned int" but has type "unsigned long".
src/acl_hal.cpp:123:3:
  path: Condition "debug_mode > 0", taking true branch.
src/acl_hal.cpp:126:5:
  printf_function: Calling "vprintf" which uses a "printf"-style format string. [Note: The source code implementation of the function has been overridden by a builtin model.]

test/acl_device_test.cpp:360:7:
  Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)

test/acl_device_test.cpp:360:7:
  invalid_type: Argument "value" to format specifier "%8x" was expected to have type "unsigned int" but has type "unsigned long".
src/acl_hal.cpp:123:3:
  path: Condition "debug_mode > 0", taking true branch.
src/acl_hal.cpp:126:5:
  printf_function: Calling "vprintf" which uses a "printf"-style format string. [Note: The source code implementation of the function has been overridden by a builtin model.]
```
@pcolberg pcolberg merged commit 9c57b77 into intel:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcolberg pcolberg pcolberg approved these changes

Assignees

@IlanTruanovsky IlanTruanovsky

Labels
bug Something isn't working
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
2 participants
@IlanTruanovsky @pcolberg