Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_configure: parse device global address in base 16 #249

Merged
merged 1 commit into from
Jan 20, 2023
Merged

auto_configure: parse device global address in base 16 #249

merged 1 commit into from
Jan 20, 2023

Conversation

sophimao
Copy link
Contributor

The compiler use a base 16 number as the device global address in the autodiscovery string, this change matches the runtime autodiscovery parsing with the compiler generated string.

@sophimao
auto_configure: parse device global address in base 16
3ab50c0 
The compiler use a base 16 number as the device global address in the
autodiscovery string, this change matches the runtime autodiscovery
parsing with the compiler generated string.
@sophimao sophimao requested a review from pcolberg January 19, 2023 15:32
pcolberg
pcolberg reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sophimao, the change looks good. How does this affect backwards-compatibility? The device global address is read as base 10 since 6f68280, which is released in 2023.1. Would reading the address as base 16 not break compatibility?

@sophimao
Copy link
Contributor Author

Would reading the address as base 16 not break compatibility?

I don't think it will, as the compiler always generates a base 16 number, even in the 2023.1 release. The reason why there is no test failures or anything is because this value currently is not used any where during host program run.

pcolberg
pcolberg approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @sophimao!

@pcolberg pcolberg merged commit c8b5554 into intel:main Jan 20, 2023
@sophimao sophimao deleted the dev_glob_addr branch January 20, 2023 13:31
@pcolberg pcolberg added the bug Something isn't working label Jan 31, 2023
@pcolberg pcolberg added this to the 2023.2 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcolberg pcolberg pcolberg approved these changes

Assignees

@sophimao sophimao

Labels
bug Something isn't working
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sophimao @pcolberg