Remove CL_CONTEXT_COMPILER_MODE_SIMULATION_INTELFPGA #244
Conversation
|
I will mention it, I think there is no down side by mentioning it. |
There was a problem hiding this comment.
Thanks @intel-liudean, and thanks @sophimao for the review. @intel-liudean, please include a description in the commit message that details why you are making the change and why the change does not cause a regression. We merge commits as is, which means the pull-request description is (mostly) irrelevant whereas the commit message is important.
Note that you won't be able to find the compiler modes via public searches since the compiler code has not been open-sourced; and unfortunately the mode uses numeric values which are hard to search for.
|
Thanks @pcolberg for the comment! It appears to me that the compiler mode here is only used in runtime though, unless I'm missing something? But you are right, it's probably hard to look for those with public searches. |
intel-liudean
force-pushed
the
simulation-device-selector
branch
from
3c4e8a6 to
67c8238
Compare
|
I have included a description in the commit message for 1) why I am making this change and 2) what tests I have done to make sure no regression happens. |
This compiler mode (simulation mode, mode 6) is unused by the runtime and hence safe to remove. I am removing it so that the differences between simulation devices and hardware devices are removed as much as possible. When we search for the compiler mode on Google, nothing returned, so it's also not documented anywhere. Tests Done: Runtime Unit Tests Checked that products/regtest/hld does not have lines like "compiler_mode => 6" or "compiler_mode => '6'"
intel-liudean
force-pushed
the
simulation-device-selector
branch
from
67c8238 to
320d4cc
Compare
There was a problem hiding this comment.
Perfect, thanks @intel-liudean! I will merge this once the integration test is complete.
|
Thank you @pcolberg for merging this change! |
This compiler mode (mode 6) is unused by the runtime, safe to remove.
When we search for the compiler mode on Google, nothing returned, so it's also not documented anywhere.
Tests Done:
Runtime Unit Tests
Checked that products/regtest/hld does not have lines like "compiler_mode => 6" or "compiler_mode => '6'"