Explicitly convert function to function pointer during comparison #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlanTruanovsky
changed the title
pcolberg
requested changes
Jan 9, 2023
There was a problem hiding this comment.
Thanks @IlanTruanovsky! Please also fix the Windows implementation of acl_dlpresent() accordingly.
IlanTruanovsky
force-pushed
the
bad-compare-1
branch
from
487c556 to
dbbc3e8
Compare
IlanTruanovsky
changed the title
nullptr instead of 0
|
Thanks @IlanTruanovsky! Could you revise the commit subject accordingly? The issue here is the implicit conversion to a function pointer, not 0 versus |
IlanTruanovsky
force-pushed
the
bad-compare-1
branch
from
dbbc3e8 to
679fa33
Compare
This fixes the following Coverity issue: src/acl_support.cpp:403:34: Type: Function address comparison (BAD_COMPARE) src/acl_support.cpp:403:34: func_conv: This implicit conversion to a function pointer is suspicious: "dlopen != NULL". src/acl_support.cpp:403:34: remediation: Did you intend to call "dlopen"?
IlanTruanovsky
force-pushed
the
bad-compare-1
branch
from
679fa33 to
fef227e
Compare
IlanTruanovsky
changed the title
nullptr instead of 0
pcolberg
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following Coverity issue: