Add copy constructor & assignment operator to acl_device_binary_t

[IlanTruanovsky]

Add default copy constructor to acl_device_binary_t to fix a Coverity issue.

Coverity issue:

include/acl_device_binary.h:25:7:
  Type: Missing assignment operator (MISSING_COPY_OR_ASSIGN)

[pcolberg]

Thanks @IlanTruanovsky for tackling this. Unless there is a specific reason to have a copyable object, you may = delete the default copy constructor and assignment operator. This may then result in a compiler error where accidental copies are made, which should be replaced with references as needed.

[pcolberg]

@IlanTruanovsky It's been a while, but I submitted a fix for the same issue in #207 and ran into this Klocwork issue. Klocwork's analysis is flawed here since the returned value is a reference into m_split_device_binaries, not a reference to a local variable. Since Klocwork is being phased out, we should go ahead and merge despite the Klocwork false positive. @zibaiwan, what do you think?

[pcolberg]

Thanks @IlanTruanovsky. This looks good; you can drop the extra empty lines since this code is boilerplate.

[zibaiwan]

@IlanTruanovsky It's been a while, but I submitted a fix for the same issue in #207 and ran into this Klocwork issue. Klocwork's analysis is flawed here since the returned value is a reference into m_split_device_binaries, not a reference to a local variable. Since Klocwork is being phased out, we should go ahead and merge despite the Klocwork false positive. @zibaiwan, what do you think?

Thanks @pcolberg for catching this false positive. I agree we should merge it.

[pcolberg]

Thanks @IlanTruanovsky. You can go ahead and squash the commits together into a single commit and force-push your branch. Revise the commit subject to match the actual changes, and in the commit message state why the change was done (to fix a Coverity issue).

[pcolberg]

Thanks @IlanTruanovsky!