Fixed coverity issue in acl_context.cpp #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxian2
changed the title
pcolberg
requested changes
Dec 7, 2022
haoxian2
force-pushed
the
coverity-acl-context
branch
from
35b4fed to
25360b6
Compare
…_CAUSES_COPY) Changed to `const cl_context _context` since coverity complains about the previous code auto _context would make an auto copy of the pointer contexts in acl_platform.contexts_set. Because `_context` is a pointer, a copy is equally as cheap as a reference, and to pass coverity which only mentions `auto` copy.
haoxian2
force-pushed
the
coverity-acl-context
branch
from
25360b6 to
f3c6fd5
Compare
pcolberg
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coverity issue in acl_context.cpp: Type: AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)
Changed to
const cl_context _contextsince coverity complains about the previous codeauto _contextwould make anautocopy of the pointer contexts in acl_platform.contexts_set.