Fixed coverity issue in acl_auto_configure.cpp #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
requested changes
Dec 5, 2022
haoxian2
force-pushed
the
coverity-acl-auto-configure
branch
from
0ece0ed to
b3b86cc
Compare
haoxian2
force-pushed
the
coverity-acl-auto-configure
branch
from
b3b86cc to
52b0682
Compare
pcolberg
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coverity issue in acl_auto_configure.cpp: Type: Unused value (UNUSED_VALUE)
Coverity was complaining that
resultdoesn't get used before being reassigned. Therefore, I just use the function itself in the argument and reset the value to 0 if the assignment fails inside ofread_int_counters. It is rather redundant, but it makes coverity happy.