Fixing coverity issues in src/acl_usm.cpp #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxian2
force-pushed
the
coverity-acl-usm
branch
from
4e928bf to
55249f8
Compare
|
@pcolberg I changed the commit message to the PR description. Thank you for the suggestion! |
Error caused because auto in for-each loop copies the iterator object from the array/list. Adding & to reference the original element. Adding const so the code don't mistakenly modify the object.
pcolberg
force-pushed
the
coverity-acl-usm
branch
from
55249f8 to
c859582
Compare
|
Thanks @haoxian2! For git commit messages, it is customary to leave an empty line between the subject and the body: --- old
+++ new
@@ -1,4 +1,5 @@
-Fixing coverity issue Type: AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)
+acl_usm: Fix coverity issue Type: AUTO_CAUSES_COPY
+
Error caused because auto in for-each loop copies the iterator object from the array/list.
Adding & to reference the original element.
Adding const so the code don't mistakenly modify the object. |
pcolberg
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
Type: AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)Error caused because
autoinfor-eachloop copies the iterator object from the array/list.Adding
&to reference the original element.Adding
constso the code don't mistakenly modify the object.