acl_profiler_test: fix undefined behaviour #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl_getenv() always returns NULL, hence the undefined behaviour was never triggered. This looks like a debugging leftover, though assert() would have been the safe alternative to dereferencing a NULL pointer. Signed-off-by: Peter Colberg <peter.colberg@intel.com>
_putenv_s() is recommended over _putenv() as a more secure variant, though the exact benefits are not detailed. Unlike the unsafe putenv() on Linux, _putenv() on Windows does appear to copy its argument. Use _putenv_s() anyway since it provides the same interface as setenv(). Signed-off-by: Peter Colberg <peter.colberg@intel.com>
The buffer passed to putenv() becomes part of the environment. It is the caller's responsibility to keep the buffer alive as long as the environment variable is not modified by a subsequent invocation. Signed-off-by: Peter Colberg <peter.colberg@intel.com>
zibaiwan
approved these changes
Nov 7, 2022
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Nov 8, 2022
Ensure each setenv() is matched with unsetenv(). This amends intel#196
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Nov 8, 2022
Ensure each setenv() is matched with unsetenv(). This amends intel#196 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
pcolberg
added a commit
that referenced
this pull request
Nov 8, 2022
Ensure each setenv() is matched with unsetenv(). This amends #196 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the final issue before enabling address sanitizer 🥳
putenv()should be replaced withacl_test_setenv()andacl_test_unsetenv()in a subsequent pull request, but for now this is sufficient to pass address sanitizer.