Pass pkg_editor tests with address sanitizer #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
force-pushed
the
pkg_editor
branch
3 times, most recently
from
d7a23a4 to
80ef266
Compare
pcolberg
force-pushed
the
pkg_editor
branch
2 times, most recently
from
08045a9 to
7409360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves various memory leaks in the
pkg_editorlibrary. The ELF library requires the user to ensure that a buffer assigned tod_bufin theElf_Datastruct is alive at the timeelf_update()is called. This was previously achieved by allocating buffers and not freeing them at all, which leaks the allocated memory. To resolve the memory leaks, these commits either introduce statically allocated buffers, or track the dynamically allocated buffers and free them when closing the ELF file.(Since I could not find detailed man pages for elfutils, I linked to the OpenBSD man pages above which are strictly for the OpenBSD implementation of libelf.)
This is a prerequisite of #118