Print Kernel hang status only in debug mode #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the earlier commit aeff9bb, this guarding conditions for the messages if (kern->io.debug_verbosity > 0) was removed accidentally, now adding it back
zibaiwan
added
bug
|
@zibaiwan Should this be backported to the 2022.3 branch? If so, after this is merged and you have the merged commit hash, please see the instructions for backporting to submit a PR against 2022.3. |
Thanks @pcolberg. I don't think this is required to be backported as there is no functional issue. The user will see their kernel status printed only if their kernel is hang. I believe it's fine to go into the next release. |
sophimao
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the earlier commit aeff9bb, this guarding conditions for the messages if (kern->io.debug_verbosity > 0) was removed accidentally, now adding it back.
Thanks @sophimao for discovering this regression.
Now the Runtime only prints the Kernel hang message in the debug mode.