Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: add buffer allocations and migrations for streaming arguments #153

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

pcolberg
Copy link
Contributor

This resolves a failure to pass local-memory sizes and global-memory
buffers as streaming arguments to a streaming kernel in simulation.

This amends #103

Signed-off-by: Peter Colberg peter.colberg@intel.com

This resolves a failure to pass local-memory sizes and global-memory
buffers as streaming arguments to a streaming kernel in simulation.

This amends intel#103

Signed-off-by: Peter Colberg <peter.colberg@intel.com>
@pcolberg pcolberg added the bug Something isn't working label Aug 10, 2022
@pcolberg pcolberg added this to the 2022.3 milestone Aug 10, 2022
@pcolberg pcolberg self-assigned this Aug 10, 2022
@pcolberg pcolberg marked this pull request as ready for review August 11, 2022 14:37
@pcolberg pcolberg requested review from sophimao and zibaiwan August 11, 2022 14:38
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter!

@pcolberg pcolberg merged commit 8336122 into intel:main Aug 16, 2022
@pcolberg pcolberg deleted the streaming_argument_buffers branch August 16, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants