-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support buffer_location for shared/host USM allocations #141
Support buffer_location for shared/host USM allocations #141
Conversation
Thanks Bain! Could you provide a brief motivation of the change in the commit message? Why is the change needed, what flows does it apply to (only IP authoring in simulation?), etc. |
I suggest we add the runtime implementation to this PR that demonstrates how the new API would work. The idea is to pass the newly received |
Sounds like a good plan! Yes, you are correct. And no, I don't think there is any additional logic required. :) |
Thanks @bsyrowik, looks good! For |
fe3d0a4
to
43023b2
Compare
Wait for integration testing before approval
@bsyrowik I have made a slight modification to store the properties in an array on the stack similar to intel/llvm#6220 and intel/llvm#6218. Once this PR passes integration testing, this is ready to be merged. |
…nd host allocation calls.
43023b2
to
9ad15f6
Compare
A board's MMD may not support passing property lists containing only a null terminator to aocl_mmd_host_alloc() or aocl_mmd_shared_alloc(). This resolves a regression introducted in intel#141 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
A board's MMD may not support passing property lists containing only a null terminator to aocl_mmd_host_alloc() or aocl_mmd_shared_alloc(). This resolves a regression introducted in #141 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
This change adds a new memory property to the aocl_mmd.h file to facilitate passing of buffer location information from the OpenCL runtime to the MMD USM allocation APIs.
The IP authoring project requires this change: USM allocations for memory-mapped host interfaces will have the buffer_location property set, and this should be propagated to the simulation MMD to ensure appropriate allocations are made (e.g. with the correct address bits set).
This complements the following SYCL runtime changes: