invocation_wrapper: support non-POD types using placement new #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
force-pushed
the
invocation_wrapper
branch
from
99b3b2a to
7245f91
Compare
Each context maintains a pool of manually allocated invocation_wrapper objects, which so far contained only POD types. To support the use of non-POD types, e.g., std::vector, explicitly invoke the constructor using placement new after malloc, and the destructor before free. https://en.cppreference.com/w/cpp/language/new#Placement_new intel#103 (comment) Signed-off-by: Peter Colberg <peter.colberg@intel.com>
pcolberg
force-pushed
the
invocation_wrapper
branch
from
7245f91 to
9a30756
Compare
zibaiwan
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each context maintains a pool of manually allocated invocation_wrapper
objects, which so far contained only POD types. To support the use of
non-POD types, e.g., std::vector, explicitly invoke the constructor
using placement new after malloc, and the destructor before free.
https://en.cppreference.com/w/cpp/language/new#Placement_new
#103 (comment)