[Device Global] Autodiscovery change #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
requested changes
Apr 4, 2022
pcolberg
requested changes
Apr 5, 2022
There was a problem hiding this comment.
Thanks @sherry-yuan, looks good! I am still unsure about the integer types which you should be able to answer by copying what the compiler does.
sherry-yuan
force-pushed
the
dev_global_autod
branch
from
b2bdd12 to
dceaee4
Compare
pcolberg
reviewed
Apr 6, 2022
pcolberg
requested changes
Apr 6, 2022
pcolberg
requested changes
Apr 6, 2022
Autodiscovery help bridge the communication between backend and runtime. The autodiscovery will contain the following information for a device global: 1. device global name 2. device global address 3. device global size The autodiscovery will be in the following format: <number of device global> <number of field in each device global> [(<name>, <address>, <size>), (...), ...]
pcolberg
force-pushed
the
dev_global_autod
branch
from
320a167 to
b0adef7
Compare
pcolberg
approved these changes
Apr 6, 2022
pcolberg
added a commit
to pcolberg/fpga-runtime-for-opencl
that referenced
this pull request
Apr 22, 2022
The stringstream err_ss is only used within the function, and the contents must be assigned to err_str which is returned to the caller. This amends intel#100 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
pcolberg
added a commit
that referenced
this pull request
Apr 25, 2022
The stringstream err_ss is only used within the function, and the contents must be assigned to err_str which is returned to the caller. This amends #100 Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodiscovery help bridge the communication between backend and runtime.
The autodiscovery will contain the following information for a device global:
The autodiscovery will be in the following format:
<number of device global> <number of field in each device global> [(<name>, <address>, <size>), (...), ...]The autodiscovery change came from #65