-
Notifications
You must be signed in to change notification settings - Fork 2
Add cicd #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add cicd #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoboivin
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One suggestion would be to try and combine the individual Jenkinsfile
files together as they are identical with the exception of the first line that distinguishes the operating system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add ci/cd pipeline for development and deployment purposes.
CI/CD is implemented using Inscopix's jenkins instance. Only Inscopix employees will be able to run these pipelines. For now builds need to be manually run, for security purposes. Since this is a public repo, we don't want to allow third-party devs to potentially modify the jenkins pipeline script in harmful ways and run on the build servers without our knowledge.
The development pipelines builds the package on all supported platforms (windows, linux, mac), installs the package in a virtual environment, and runs unit tests. The deployment pipeline does everything the development pipeline does, but also publishes the wheel files to pypi if the unit tests pass.
Testing Instructions
See build status on PR. Everyone can see the status, but only Inscopix employees can navigate to the jenkins instance to examine in more detail.
Added/updated tests?