Skip to content

Add cicd #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 7, 2025
Merged

Add cicd #59

merged 22 commits into from
Jan 7, 2025

Conversation

nosheen-adil
Copy link
Contributor

@nosheen-adil nosheen-adil commented Nov 29, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add ci/cd pipeline for development and deployment purposes.

CI/CD is implemented using Inscopix's jenkins instance. Only Inscopix employees will be able to run these pipelines. For now builds need to be manually run, for security purposes. Since this is a public repo, we don't want to allow third-party devs to potentially modify the jenkins pipeline script in harmful ways and run on the build servers without our knowledge.

The development pipelines builds the package on all supported platforms (windows, linux, mac), installs the package in a virtual environment, and runs unit tests. The deployment pipeline does everything the development pipeline does, but also publishes the wheel files to pypi if the unit tests pass.

Testing Instructions

See build status on PR. Everyone can see the status, but only Inscopix employees can navigate to the jenkins instance to examine in more detail.

Added/updated tests?

  • Yes
  • No, and this is why: Unit tests did not need updates, existing tests pass on jenkins across OS
  • I need help with writing tests

@nosheen-adil nosheen-adil requested a review from a team as a code owner November 29, 2024 04:44
Copy link
Contributor

@brunoboivin brunoboivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One suggestion would be to try and combine the individual Jenkinsfile files together as they are identical with the exception of the first line that distinguishes the operating system.

@nosheen-adil nosheen-adil merged commit a6f222f into main Jan 7, 2025
3 checks passed
@nosheen-adil nosheen-adil deleted the add_cicd branch January 7, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants