Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: kubefire install messes with unit files #34

Closed
rugwirobaker opened this issue Oct 1, 2020 · 1 comment
Closed

Bug: kubefire install messes with unit files #34

rugwirobaker opened this issue Oct 1, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@rugwirobaker
Copy link

Describe the bug
I have recently come to realize that every time there is a new version and I do kubefire installl it modifies my containerd systemd configuration: /etc/systemd/system/containerd.service

Specifically the location of chgrp binary:

....
[Service]
ExecStartPre=-/sbin/modprobe overlay
ExecStart=/usr/local/bin/containerd
ExecStartPost=/usr/bin/chgrp containerd /run/containerd/containerd.sock
....

Running $ which chgrp on my system shows me mine is at /bin/chgrp. Thus on my next start up docker fails to start since it has been changed to usr/bin/chgrp:

 docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/docker.service.d
           └─hosts.conf
   Active: inactive (dead)
     Docs: https://docs.docker.com

Ukw 01 17:26:12 citronus systemd[1]: Dependency failed for Docker Application Container Engine.
Ukw 01 17:26:12 citronus systemd[1]: docker.service: Job docker.service/start failed with result 'dependency'.
Ukw 01 17:26:21 citronus systemd[1]: Dependency failed for Docker Application Container Engine.
Ukw 01 17:26:21 citronus systemd[1]: docker.service: Job docker.service/start failed with result 'dependency'.
Ukw 01 17:26:26 citronus systemd[1]: Dependency failed for Docker Application Container Engine.
Ukw 01 17:26:26 citronus systemd[1]: docker.service: Job docker.service/start failed with result 'dependency'.

To Reproduce
Run kubefire install on a system whose required binaries are not in the expected location.

Expected behavior
Should not modify the unit files without warning or approval

Environment

  • OS version
➜  ~ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

  • Kubefire version
➜  ~ kubefire version
Version: v0.3.0
Build: 344f34d-20200924143906

  • Kubefire runtime info
➜  ~ kubefire info
CONTAINERD	IGNITE	CNI   	RUNC      	CNIPLUGIN                 
v1.4.1    	v0.7.1	v0.8.7	1.0.0-rc92	0.4.0/kubefire-cni-bridge	

Additional context
My docker environment was installed via the official tutorial for Ubuntu system: https://docs.docker.com/engine/install/ubuntu/

@rugwirobaker rugwirobaker added the bug Something isn't working label Oct 1, 2020
@innobead
Copy link
Owner

@rugwirobaker thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants