chore: adds lion-input-amount-dropdown #2505
Open
+1,868
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bbccc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/ui/components/input-amount-dropdown/test-suites/LionInputAmountDropdown.suite.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/test-suites/LionInputAmountDropdown.suite.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/test-suites/LionInputAmountDropdown.suite.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/src/currencyUtil.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/src/LionInputAmountDropdown.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/test-suites/LionInputAmountDropdown.suite.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/test-suites/LionInputAmountDropdown.suite.js
Show resolved
Hide resolved
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
thatdudemanguy
changed the title
thatdudemanguy
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
...gram/analyzers/e2e/find-classes_-_importing-target-project_0.0.2-target-mock__868447312.json
Outdated
Show resolved
Hide resolved
| static properties = { | ||
| preferredCurrencies: { type: Array }, | ||
| allowedCurrencies: { type: Array }, | ||
| __dropdownSlot: { type: String }, |
There was a problem hiding this comment.
Private properties should be written with a #. We are slowly applying this throughout the lion repo.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_properties
Suggested change
| __dropdownSlot: { type: String }, | |
| #dropdownSlot: { type: String }, |
There was a problem hiding this comment.
yeah I agree, however; last time I checked using # in lit properties didn't work.
packages/ui/components/input-amount-dropdown/src/LionInputAmountDropdown.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/src/LionInputAmountDropdown.js
Outdated
Show resolved
Hide resolved
packages/ui/components/input-amount-dropdown/src/LionInputAmountDropdown.js
Outdated
Show resolved
Hide resolved
…ntDropdown.js Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
thatdudemanguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
input-amount-dropdowntest cases and suite to define the spec of the new component, according to the pre-existinginput-tel-dropdownstructure.input-amount-dropdowncomponent according to the test cases.