Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Substrate no-std check as it won't build on latest nightlies #1302

Merged
merged 2 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions .github/workflows/no-std.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,18 @@ jobs:
cd tools/no-std-check
make check-panic-conflict

check-substrate:
name: Check no_std substrate support
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
toolchain: nightly
target: wasm32-unknown-unknown
override: true
- run: |
cd tools/no-std-check
make check-substrate
# Disabled until sp-io removes this feature which was removed in latest nightlies:
# https://github.com/paritytech/substrate/blob/b5846ccc8480806aa6035ae4d2e89d61930f697e/primitives/io/src/lib.rs#L22
# check-substrate:
# name: Check no_std substrate support
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - uses: actions-rs/toolchain@v1
# with:
# toolchain: nightly
# target: wasm32-unknown-unknown
# override: true
# - run: |
# cd tools/no-std-check
# make check-substrate
2 changes: 1 addition & 1 deletion tools/kvstore-test/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ tendermint-light-client = { version = "0.31.1", path = "../../light-client", fea
tendermint-rpc = { version = "0.31.1", path = "../../rpc", features = [ "http-client", "websocket-client" ] }
tokio = { version = "1.0", features = [ "rt-multi-thread", "macros" ] }
tracing = "0.1"
tracing-subscriber = "0.2"
tracing-subscriber = "0.3"
contracts = "0.4.0"
serde_json = "1"
2 changes: 1 addition & 1 deletion tools/kvstore-test/Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ args = ["run", "--name", "${CONTAINER_NAME}", "--rm", "--publish", "26657:${HOST
dependencies = ["docker-up-stop-old", "docker-up-rm-old"]

[tasks.test]
args = ["test", "--all-features", "--", "--nocapture"]
args = ["test", "--all-features", "--", "--nocapture", "--test-threads=1"]

[tasks.docker-stop]
command = "docker"
Expand Down