Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify IBC transfer test to reproduce connection handshake error #1980

Closed
wants to merge 1 commit into from
Closed

Modify IBC transfer test to reproduce connection handshake error #1980

wants to merge 1 commit into from

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Mar 17, 2022 •
edited
Loading

Description

Modify test_ibc_transfer to reproduce connection handshake error in #1971 by setting chain_config.max_msg_num to 1.

To reproduce this locally, run:

cargo test -p ibc-integration-test -- test_ibc_transfer

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen mentioned this pull request Mar 17, 2022
Closed
5 tasks
@adizere
Copy link
Member

adizere commented May 2, 2022

Will be address in #2163.

1 similar comment
@adizere
Copy link
Member

adizere commented May 2, 2022

Will be address in #2163.

@adizere adizere closed this May 2, 2022
@adizere adizere closed this May 2, 2022
@romac romac deleted the soares/max-msg-num-1 branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soareschen @adizere