fix: backport improvements to ReadTags pushdowns from 2.x #23302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
reviewed
Apr 26, 2022
| @@ -311,6 +355,16 @@ func (s *Store) TagKeys(ctx context.Context, req *datatypes.TagKeysRequest) (cur | |||
| if found := reads.HasFieldValueKey(expr); found { | |||
| return nil, errors.New("field values unsupported") | |||
| } | |||
| if found := reads.ExprHasKey(expr, fieldKey); found { | |||
There was a problem hiding this comment.
This is going to be extremely expensive to compute, right? Previously we could always consult the series index for this call, but now we have to go to TSM for every series key/field key combination to find out if data exists for that key.
Do we expect the UI features that require this to be usable for large databases?
jeffreyssmith2nd
force-pushed
the
ds-flux-tag-values-backport
branch
from
0765a22 to
a8a3ebe
Compare
jeffreyssmith2nd
force-pushed
the
ds-flux-tag-values-backport
branch
from
7ac4d28 to
ac720bb
Compare
jeffreyssmith2nd
force-pushed
the
ds-flux-tag-values-backport
branch
from
ac720bb to
dcd88d6
Compare
|
@jeffreyssmith2nd - what's the status on this one? |
|
This passes all the existing tests. It was, however, not the solution to the problem that we originally thought it was. Given its potential to impact performance, I am uncertain of if we want to merge it without a good use requiring it. |
|
Closing this PR per comments above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #21160, which was a backport of #19856 and #19894.
The backport of #19856 updates the
tagKeysandtagValuesmethods of theStoreinterface to return the answers that Flux is used to, by properly filtering on_fieldwhen such a predicate is present. These methods are frequently used by the UI query builder to describe the shape of the users data. This primarily fixed #19794 for 2.x, which contains good examples of the issue, but also fixed #19806, a related issueThe backport of #19894 returns
nilinstead of an empty iterator, and callers expect a non-nil result set for any non-error return, which fixed influxdata/flux#3300 for 2.xThis work was originally shelved due to complications regarding Enterprise compatibility. As it stands now, this work is identical to where #21160 was left off, though I expect that this will have to be adjusted significantly to make work for what we need. Some aspects of the wire-format has changed, so we may want to undo those portions of it, or be prepared to handle it carefully