chore: remove duplicate flux test #22035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of deleting this test entirely, could we rewrite it to run the test from flux with an extra assertion that our expected pushdown rule is being used? Some examples from the group-aggregate tests: https://github.com/influxdata/influxdb/blob/master/query/stdlib/influxdata/influxdb/group_first_last_influxdb_test.flux |
Seems like a good idea, converted the test! |
danxmoran
approved these changes
Aug 4, 2021
williamhbaker
added a commit
that referenced
this pull request
Aug 9, 2021
* chore: remove duplicate flux test * test: convert to a pushdown test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21970
This removes the duplicate test that was added with #21962
Now that flux has been updated to the latest version with #22023, I confirmed that the test currently runs twice, so removing it here will cause it only to be run once from the flux dependency.
CI job showing that the test is still run, but only once: https://app.circleci.com/pipelines/github/influxdata/influxdb/22530/workflows/2edbf7c5-2feb-48af-9af3-b7daae01821d/jobs/204260 (expand the
make test-fluxstep and look forshow_fields_with_meas_pred)