build: upgrade staticcheck, fix new linter warnings #21957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Jul 27, 2021
| @@ -351,8 +351,7 @@ func (e *Executor) recover(query *influxql.Query, results chan *Result) { | |||
|
|
|||
| if willCrash { | |||
| e.log.Error("\n\n=====\nAll goroutines now follow:") | |||
| buf := debug.Stack() | |||
| e.log.Error(fmt.Sprintf("%s", buf)) | |||
| e.log.Error(string(debug.Stack())) | |||
danxmoran
commented
Jul 27, 2021
| @@ -499,7 +499,7 @@ type Stats struct { | |||
| NTags int | |||
| } | |||
|
|
|||
| func (s Stats) Update(o Stats) { | |||
| func (s Stats) Update(o Stats) Stats { | |||
There was a problem hiding this comment.
Bug: This method does a lot of updates to the fields of s, but since it wasn't being passed as a reference none of the updates were having an effect. I decided to keep the pass-by-value here and return the new data because at the callsite s is a member of a map, so getting a reference to it is a pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while messing around with the build, the latest version of
staticcheckis more module-/cgo-aware and comes with more checks. Bumping the version revealed one style nitpick and one outright bug.