feat(flux): add window aggregate pushdown rules #21085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Mar 29, 2021
| @@ -3,6 +3,7 @@ package influxdb | |||
| import ( | |||
There was a problem hiding this comment.
Copy-paste from 2.x
| @@ -2,6 +2,7 @@ package influxdb | |||
|
|
|||
There was a problem hiding this comment.
Copy-paste from 2.x
| @@ -2,6 +2,7 @@ package influxdb_test | |||
|
|
|||
There was a problem hiding this comment.
Copy-paste from 2.x
| @@ -7,6 +7,7 @@ import ( | |||
| "github.com/influxdata/flux" | |||
There was a problem hiding this comment.
Copy-paste from 2.x
| @@ -6,6 +6,7 @@ require ( | |||
| collectd.org v0.3.0 | |||
| github.com/BurntSushi/toml v0.3.1 | |||
| github.com/apache/arrow/go/arrow v0.0.0-20200923215132-ac86123a3f01 | |||
| github.com/benbjohnson/tmpl v1.0.0 // indirect | |||
There was a problem hiding this comment.
This was added automatically when I ran go generate, seems reasonable to have a version pinned here
| @@ -1,5 +1,7 @@ | |||
| package reads | |||
|
|
|||
| //go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@types.tmpldata flux_table.gen.go.tmpl | |||
There was a problem hiding this comment.
Copy-pasted from 2.x
| @@ -1 +1,4 @@ | |||
| package reads | |||
|
|
|||
| //go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata array_cursor.gen.go.tmpl | |||
| //go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata -o=array_cursor_gen_test.go array_cursor_test.gen.go.tmpl | |||
There was a problem hiding this comment.
Copy-pasted from 2.x
| @@ -4,7 +4,6 @@ import ( | |||
| "bytes" | |||
There was a problem hiding this comment.
Copy-pasted from 2.x
| @@ -0,0 +1,32 @@ | |||
| [ | |||
There was a problem hiding this comment.
Copy-pasted from 2.x
| @@ -0,0 +1,190 @@ | |||
| package reads | |||
There was a problem hiding this comment.
Copy-pasted from 2.x
|
Closing this; will reopen in smaller pieces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21069
Builds off of #21074
This took a lot more code than I expected, but the majority of what's added here is copied verbatim (maybe with import fixups) from 2.x. I'll comment explanations on each file.
Still TODO: Write some test cases using the new Flux test harness