feat(query): enable min/max pushdown #20994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
3 times, most recently
from
2141b37 to
43f72dc
Compare
9 tasks
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
2 times, most recently
from
86d9780 to
6d5235f
Compare
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
3 times, most recently
from
fe9745e to
89cf604
Compare
fchikwekwe
requested review from
a team and
wolffcm
and removed request for
a team
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
from
89cf604 to
65c3851
Compare
wolffcm
reviewed
Apr 2, 2021
| "PushDownRangeRule": 1, | ||
| "PushDownFilterRule": 1, | ||
| ]) | ||
| group_min_test.group_min_bare() |
There was a problem hiding this comment.
I'm looking at the test that this test extends, and I see that it's filtering by _value:
https://github.com/influxdata/flux/blob/1f16d09633be04ace0b806bbaa90db59ee4ff15a/stdlib/planner/group_min_test.flux#L25
The test for max is similar. This doesn't seem like it would actually validate that these functions work correctly. Am I missing something?
fchikwekwe
commented
Apr 2, 2021
| t.appendBounds(colReader) | ||
| return true | ||
| } | ||
|
|
||
| type {{.name}}AggregateMethod func([]int64, []{{.Type}}) (int64, {{.Type}}) | ||
| type {{.Name}}AggregateAccumulator interface { |
There was a problem hiding this comment.
@wolffcm This file has a lot of the bug fix work that you were looking for.
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
from
a5383df to
8a4b490
Compare
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
9 times, most recently
from
72e7186 to
fb21461
Compare
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
from
94919fb to
d76cd24
Compare
fchikwekwe
force-pushed
the
feat/min-max-pushdown
branch
from
d76cd24 to
fb29389
Compare
wolffcm
approved these changes
Apr 20, 2021
|
Yay! At last :) |
dgnorton
pushed a commit
that referenced
this pull request
Apr 20, 2021
* feat(query): enable min/max pushdown * fix(query): fix the group last pushdown to use descending cursors * test(storage): add read group test with no agg Co-authored-by: Jonathan A. Sternberg <jonathan@influxdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #