fix: stop backup temp file leakage

[alxric]

Since this loop does not exist on success, snapshot operation is
executed three times regardless, and once succesful it only cleans up
after the last run, leaving temporary files from the previous 2 runs
behind, on top of creating unnecessary load on the system.

• [ x] Well-formatted commit messages
• [x ] Signed CLA (if not already signed)

[danxmoran]

Hi @alxric, thanks for the submission! The git conflict here is caused by the merging of #20527, which we believe fixes the temp file leakage. Can you take a look at the patch there and let me know if you think there's any difference in end behavior between the two approaches?

[alxric]

Hi @alxric, thanks for the submission! The git conflict here is caused by the merging of #20527, which we believe fixes the temp file leakage. Can you take a look at the patch there and let me know if you think there's any difference in end behavior between the two approaches?

Ah I missed that PR. End result looks like it would be the same, so closing this. Thanks!