Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): use methods to set storage engine loggers #20411

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #20410

Backports part of #20313. The WithLogger methods do some extra work that was getting skipped.

@danxmoran danxmoran force-pushed the dm-backport-storage-logger-fix-20410 branch from 8d95cde to 0927f4c Compare December 23, 2020 21:39
@danxmoran danxmoran force-pushed the dm-backport-storage-logger-fix-20410 branch from 0927f4c to af35168 Compare January 5, 2021 17:53
@danxmoran danxmoran requested a review from psteinbachs January 5, 2021 23:18
Copy link
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@danxmoran danxmoran force-pushed the dm-backport-storage-logger-fix-20410 branch from af35168 to 4cf16b0 Compare January 6, 2021 00:17
@danxmoran danxmoran merged commit cdac548 into 2.0 Jan 6, 2021
@danxmoran danxmoran deleted the dm-backport-storage-logger-fix-20410 branch January 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants