fix: enforce max query queue size to avoid panic #20157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
approved these changes
Nov 23, 2020
| // MaxQueryQueueSize is the max allowable value for QueueSize | ||
| // in controller config. The setting was found by trial-and-error, | ||
| // it's the max size that can be passed to `makechan` for a channel | ||
| // of struct pointers (also of int64s) without hitting a panic. |
There was a problem hiding this comment.
Can you provide more info on the panic location so we can track future improvements to GoLang and possibly change this? Is there a known issue in GoLang we could reference, for instance?
|
@davidby-influx I'm going to close this one, and push a different implementation into #20149. The type-driven implementation should work for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20145
The max value I picked is pretty strange, and if you actually try to use it the system tries to allocate TBs of memory and OOMs, but I couldn't think of a better (explainable) option.