-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade version of jwt-go package to v4.0.0 #19893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address CVE-2020-26160 for the jwt-go package.
docmerlin
previously approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming it passes CI.
Prior to this commit, the TestHandler_Query_Auth() tests would fail as it checked for specific error strigns returned by the jwt-go package. Version 4.0.0-preview1 of the package changed the verbiage of those errors a bit. This patch updates the test to detect the new error string.
docmerlin
suggested changes
Nov 5, 2020
docmerlin
approved these changes
Nov 5, 2020
ayang64
added a commit
that referenced
this pull request
Nov 5, 2020
This commit updates the dependencies for influxdb to require v4.0.0-preview1 of the jwt-go package. This required updating the go.mod and go.sum files as well as any source file that directly imported that package. Prior to this commit, the TestHandler_Query_Auth() tests would fail as it checked for specific error strigns returned by the jwt-go package. Version 4.0.0-preview1 of the package changed the verbiage of those errors a bit. This patch updates the test to detect the new error string.
ayang64
added a commit
that referenced
this pull request
Nov 6, 2020
This commit updates the dependencies for influxdb to require v4.0.0-preview1 of the jwt-go package. This required updating the go.mod and go.sum files as well as any source file that directly imported that package. Prior to this commit, the TestHandler_Query_Auth() tests would fail as it checked for specific error strigns returned by the jwt-go package. Version 4.0.0-preview1 of the package changed the verbiage of those errors a bit. This patch updates the test to detect the new error string.
dgnorton
pushed a commit
that referenced
this pull request
Feb 3, 2021
This commit updates the dependencies for influxdb to require v4.0.0-preview1 of the jwt-go package. This required updating the go.mod and go.sum files as well as any source file that directly imported that package. Prior to this commit, the TestHandler_Query_Auth() tests would fail as it checked for specific error strigns returned by the jwt-go package. Version 4.0.0-preview1 of the package changed the verbiage of those errors a bit. This patch updates the test to detect the new error string.
davidby-influx
pushed a commit
that referenced
this pull request
Mar 2, 2021
This commit updates the dependencies for influxdb to require v4.0.0-preview1 of the jwt-go package. This required updating the go.mod and go.sum files as well as any source file that directly imported that package. Prior to this commit, the TestHandler_Query_Auth() tests would fail as it checked for specific error strigns returned by the jwt-go package. Version 4.0.0-preview1 of the package changed the verbiage of those errors a bit. This patch updates the test to detect the new error string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address CVE-2020-26160 for the jwt-go package.
Closes #
Describe your proposed changes here.