fix: typos #19751

kumakichi · 2020-10-15T08:48:57Z

fix some typos

CHANGELOG.md updated with a link to the PR (not the Issue)
Well-formatted commit messages
Rebased/mergeable
Tests pass
http/swagger.yml updated (if modified Go structs or API)
Feature flagged (if modified API)
Documentation updated or issue created (provide link to issue/pr)
Signed CLA (if not already signed)

russorat · 2020-11-05T18:08:38Z

chronograf/bolt/dashboards.go

@@ -13,7 +13,7 @@ import (
 var _ chronograf.DashboardsStore = &DashboardsStore{}

 // DashboardsBucket is the bolt bucket dashboards are stored in
-var DashboardsBucket = []byte("Dashoard")
+var DashboardsBucket = []byte("Dashboard")


not sure if this is dead code or not, but worried it might have larger impacts.

@glinton I feel like you might be able to answer if this has larger impacts

last i knew it was still being used and changing it would cause old dashboards to go missing. if it's worth it to update this spelling, a migration would need to be written

The only place i found this to be used was in cmd/chronograf-migrator, I think this particular change should be reverted since chronograf still stores dashboards in that misspelled bucket.

migrator code

chronograf code

If cmd/chronograf-migrator is not the preferred method to migrate from v1, then all this code could be removed.

russorat · 2020-11-05T20:21:48Z

e2e/src/step_definitions/dashboards/dashboardStepDefs.js

@@ -246,7 +246,7 @@ When(/^move horizontally to "(.*)" of graph cell named "(.*)"$/, async (fraction
 });

 When(/^drag horizontally to "(.*)" of graph cell named "(.*)"$/, async (fraction, name) => {
-    await dbdSteps.dragToHorizonatlFractionOfGraphCell(fraction, name);
+    await dbdSteps.dragToHorizontalFractionOfGraphCell(fraction, name);


russorat · 2020-11-05T20:22:02Z

e2e/src/step_definitions/dashboards/dashboardsStepDefs.js

@@ -107,7 +107,7 @@ When(/^enter "(.*)" in the popover label selector filter$/, async text => {
 });

 Then(/^there are "(.*)" label pills in the select label popover$/, async count => {
-    await dbdsSteps.verifyDasboardAddLabelsPillCount(count);
+    await dbdsSteps.verifyDashboardAddLabelsPillCount(count);


russorat · 2020-11-05T20:22:10Z

e2e/src/step_definitions/dashboards/dashboardsStepDefs.js

@@ -127,7 +127,7 @@ Then(/^the dashboard card "(.*)" has the label "(.*)"$/, async (name, label) =>
 });

 When(/^click the add label button for the dashboard card "(.*)"$/, async name => {
-    await dbdsSteps.clickDasboardCardAddLabel(name);
+    await dbdsSteps.clickDashboardCardAddLabel(name);


russorat · 2020-11-05T20:22:21Z

e2e/src/step_definitions/dataExplorer/dataExplorerStepDefs.js

@@ -42,7 +42,7 @@ When(/^move horizontally to "(.*)" of the graph$/, async (fraction) => {
 });

 When(/^drag horizontally to "(.*)" of the graph$/, async (fraction) => {
-    await deSteps.dragToHorizonatalFractionOfGraph(fraction);
+    await deSteps.dragToHorizontalFractionOfGraph(fraction);


russorat · 2020-11-05T20:22:34Z

e2e/src/steps/dashboards/dashboardsSteps.js

@@ -132,7 +132,7 @@ class dashboardsSteps extends influxSteps {
        await this.typeTextAndWait(await this.dbdsPage.getAddLabelsPopoverFilter(), text);
    }

-    async verifyDasboardAddLabelsPillCount(count){
+    async verifyDashboardAddLabelsPillCount(count){


russorat · 2020-11-05T20:22:45Z

e2e/src/steps/dashboards/dashboardsSteps.js

@@ -155,7 +155,7 @@ class dashboardsSteps extends influxSteps {
        await this.assertVisible(await this.dbdsPage.getDashboardCardLabelPill(name, label));
    }

-    async clickDasboardCardAddLabel(name){
+    async clickDashboardCardAddLabel(name){


russorat · 2020-11-05T20:22:55Z

e2e/src/steps/dataExplorer/dataExplorerSteps.js

@@ -153,7 +153,7 @@ class dataExplorerSteps extends influxSteps {
        });
    }

-    async dragToHorizonatalFractionOfGraph(fraction){
+    async dragToHorizontalFractionOfGraph(fraction){


russorat · 2020-11-05T20:23:13Z

e2e/src/utils/performanceUtils.js

@@ -111,7 +111,7 @@ const writePerformanceLog = async () => {
  console.log()
 };

-const writePerfomanceReport = async (filename = performanceRecFile) => {
+const writePerformanceReport = async (filename = performanceRecFile) => {


russorat · 2020-11-05T20:23:26Z

endpoints/service_test.go

 // see https://github.com/influxdata/influxdb/pull/19082 for details
-func TestEndpointService_cummulativeSecrets(t *testing.T) {
+func TestEndpointService_cumulativeSecrets(t *testing.T) {


russorat · 2020-11-05T20:25:25Z

mock/dashboard_service.go

@@ -28,9 +28,9 @@ type DashboardService struct {
 	GetDashboardCellViewCalls    SafeCount
 	UpdateDashboardCellViewF     func(ctx context.Context, dashboardID platform.ID, cellID platform.ID, upd platform.ViewUpdate) (*platform.View, error)
 	UpdateDashboardCellViewCalls SafeCount
-	UpdateDashboardCellF         func(ctx context.Context, dashbaordID platform.ID, cellID platform.ID, upd platform.CellUpdate) (*platform.Cell, error)
+	UpdateDashboardCellF         func(ctx context.Context, dashboardID platform.ID, cellID platform.ID, upd platform.CellUpdate) (*platform.Cell, error)


code (mock)

russorat · 2020-11-05T20:25:42Z

mock/nats.go

@@ -34,11 +34,11 @@ func NewNats() (nats.Publisher, nats.Subscriber) {
 		server: server,
 	}

-	subcriber := &NatsSubscriber{
+	subscriber := &NatsSubscriber{


code (mock)

russorat · 2020-11-05T20:25:54Z

notification/check/check_test.go

@@ -141,7 +141,7 @@ func TestValidCheck(t *testing.T) {
 			},
 		},
 		{
-			name: "bad thredshold",
+			name: "bad threshold",


code (test)

russorat · 2020-11-05T20:26:34Z

session.go

-// SessionAuthorizionKind defines the type of authorizer
-const SessionAuthorizionKind = "session"
+// SessionAuthorizationKind defines the type of authorizer
+const SessionAuthorizationKind = "session"


russorat · 2020-11-05T20:27:59Z

ui/src/checks/utils/index.ts

@@ -4,7 +4,7 @@ import {PostCheck} from 'src/client'

 // Utils
 import {checkThresholdsValid} from './checkValidate'
-import {isDurationParseable} from 'src/shared/utils/duration'
+import {isDurationParsable} from 'src/shared/utils/duration'


russorat · 2020-11-05T20:28:14Z

ui/src/dashboards/utils/time.ts

@@ -1,7 +1,7 @@
 import {CustomTimeRange, TimeRange, DurationTimeRange} from 'src/types/queries'

 import {SELECTABLE_TIME_RANGES} from 'src/shared/constants/timeRanges'
-import {isDurationWithNowParseable} from 'src/shared/utils/duration'
+import {isDurationWithNowParsable} from 'src/shared/utils/duration'


russorat · 2020-11-05T20:28:32Z

ui/src/members/components/Members.test.tsx

@@ -6,11 +6,11 @@ import {shallow} from 'enzyme'
 import MemberList from 'src/members/components/MemberList'

 // Constants
-import {resouceOwner} from 'src/members/dummyData'
+import {resourceOwner} from 'src/members/dummyData'


code (test)

russorat · 2020-11-05T20:28:40Z

ui/src/members/dummyData.ts

@@ -1,6 +1,6 @@
 import {ResourceOwner, User} from '@influxdata/influx'

-export const resouceOwner: ResourceOwner[] = [
+export const resourceOwner: ResourceOwner[] = [


russorat · 2020-11-05T20:29:13Z

ui/src/shared/components/DurationInput.tsx

@@ -8,7 +8,7 @@ import {
  ClickOutside,
  ComponentStatus,
 } from '@influxdata/clockface'
-import {isDurationParseable} from 'src/shared/utils/duration'
+import {isDurationParsable} from 'src/shared/utils/duration'


dgnorton · 2020-11-05T20:29:18Z

@kumakichi can you rebase this PR to resolve the conflicts?

russorat · 2020-11-05T20:29:33Z

ui/src/shared/components/ThresholdSetting.tsx

@@ -60,7 +60,7 @@ const ThresholdSetting: FunctionComponent<Props> = ({
    label = 'Value is >='
  }

-  const isRemoveable =
+  const isRemovable =


russorat · 2020-11-05T20:29:46Z

ui/src/shared/components/ThresholdsSettings.test.tsx

@@ -113,14 +113,14 @@ describe('ThresholdSettings', () => {

  test('broadcasts edited thresholds only when changes are valid', async () => {
    const handleSetThresholdsSpy = jest.fn()
-    const testShresholds: Color[] = [
+    const testThresholds: Color[] = [


code (test)

russorat · 2020-11-05T20:30:02Z

ui/src/shared/utils/duration.test.tsx

@@ -3,8 +3,8 @@ import {
  durationToMilliseconds,
  areDurationsEqual,
  millisecondsToDuration,
-  isDurationWithNowParseable,
-  isDurationParseable,
+  isDurationWithNowParsable,


code (test)

russorat · 2020-11-05T20:30:14Z

ui/src/shared/utils/duration.ts

@@ -7,7 +7,7 @@ import {TIME_RANGE_FORMAT} from 'src/shared/constants/timeRanges'
 export const removeSpacesAndNow = (input: string): string =>
  input.replace(/\s/g, '').replace(/now\(\)-/, '')

-export const isDurationWithNowParseable = (lower: string): boolean => {
+export const isDurationWithNowParsable = (lower: string): boolean => {


russorat · 2020-11-05T20:36:10Z

Thanks! reviewed and commented on any areas where the typos were code and not comments or strings. Finding eng team members to take a look as well.

danxmoran · 2020-11-06T17:13:31Z

@russorat I'll get this rebased

danxmoran · 2020-11-06T20:25:04Z

Looks like GitHub is going to force me to open a fresh PR to pushed the rebased changes. Holding off for now.

danxmoran · 2020-11-11T14:35:26Z

Closing in favor of the rebased version #19987

fix: typo

dbc26fe

kumakichi requested a review from a team as a code owner October 15, 2020 08:48

fix: build

1a85d3e

russorat reviewed Nov 5, 2020

View reviewed changes

russorat requested review from psteinbachs and removed request for a team November 5, 2020 20:13

russorat reviewed Nov 5, 2020

View reviewed changes

russorat mentioned this pull request Nov 5, 2020

fix: minor typos in readmes influxdata/telegraf#8370

Merged

3 tasks

danxmoran self-assigned this Nov 6, 2020

danxmoran removed their assignment Nov 6, 2020

danxmoran self-assigned this Nov 11, 2020

danxmoran mentioned this pull request Nov 11, 2020

fix: correct various typos #19987

Merged

8 tasks

danxmoran closed this Nov 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: typos #19751

fix: typos #19751

kumakichi commented Oct 15, 2020 •

edited

Loading

russorat Nov 5, 2020

hoorayimhelping Nov 6, 2020

glinton Nov 7, 2020

glinton Nov 10, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

dgnorton commented Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat Nov 5, 2020

russorat commented Nov 5, 2020

danxmoran commented Nov 6, 2020

danxmoran commented Nov 6, 2020

danxmoran commented Nov 11, 2020

fix: typos #19751

fix: typos #19751

Conversation

kumakichi commented Oct 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgnorton commented Nov 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

russorat commented Nov 5, 2020

danxmoran commented Nov 6, 2020

danxmoran commented Nov 6, 2020

danxmoran commented Nov 11, 2020

kumakichi commented Oct 15, 2020 •

edited

Loading