Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification/teams): add teams notification - server side #19744

Closed
wants to merge 1 commit into from

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Oct 14, 2020

This PR adds support for Microsoft Teams in InfluxDB notification endpoints and notification rules to the server-side of InfluxDB.
It contains code changes that were reviewed in #18916 (which also contained UI part, which is not subject of this PR)

What is in this PR:

  • implementation and tests of teams endpoint and rule
  • swagger updated with teams notification rule and endpoint
  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@sranka sranka force-pushed the 17939/teamsNotification_server branch from fd567b9 to c6e96ff Compare October 14, 2020 14:02
@sranka
Copy link
Contributor Author

sranka commented Oct 14, 2020

If I include swagger update in this PR, UI-dependant automated tests fail (ci/circleci: jlint, jstest, build fail). The root cause is that the UI code cannot be built against types that are generated from an updated swagger file. I could possibly update UI types (as I originally did #18916), but this is AFAIK in a different repo (influxdata/ui). Any advice on how to proceed with this tension between ui and influxdb repositories?

52f99f3 is the swagger change, it is only additive.

@sranka sranka marked this pull request as ready for review October 14, 2020 14:23
@jacobmarble jacobmarble closed this Jan 2, 2024
@jacobmarble jacobmarble deleted the 17939/teamsNotification_server branch January 2, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants