Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(write): refactor batcher to reuse code #19723

Merged
merged 1 commit into from
Oct 13, 2020
Merged

chore(write): refactor batcher to reuse code #19723

merged 1 commit into from
Oct 13, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Oct 11, 2020 •
edited
Loading

This PR improves and simplifies what was done in #19658 in write/batcher.go in a way that the newly introduced WriteTo(filter) implementation reuses the same code as the existing Write(org, bucket).

The newly added WriteTo implementation is then also covered by existing tests, the coverage of write package code is back to 100%.

@sranka sranka marked this pull request as ready for review October 11, 2020 11:38
@sranka
Copy link
Contributor Author

sranka commented Oct 11, 2020

@glinton please take a look, I need this to be merged before I continue with #19722 and #18327

@sranka sranka requested a review from glinton October 11, 2020 11:43
@sranka sranka merged commit a171c4e into master Oct 13, 2020
@jacobmarble jacobmarble deleted the 19658/refactor_batcher branch January 2, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sranka @glinton