feat: Port 1.x retention policy enforcement service #19521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
sgc/issue/19309
branch
3 times, most recently
from
6c1a5ce to
faed872
Compare
stuartcarnie
requested review from
a team,
sebito91 and
benbjohnson
and removed request for
a team and
sebito91
benbjohnson
approved these changes
Sep 9, 2020
v1/services/retention/config.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // TODO: Should we enforce a minimum interval? |
There was a problem hiding this comment.
I'm not sure it's worth adding minimums. Hopefully people won't be adjusting this config option at all.
There was a problem hiding this comment.
Will remove that comment
v1/services/retention/service.go
Outdated
|
|
||
| config Config | ||
| wg sync.WaitGroup | ||
| done chan struct{} |
There was a problem hiding this comment.
Minor nit. This is probably just ported over from the previous implementation but I like using a cancelable background context instead of a done channel. It handles idempotency during closing and a lot of things already take a context.Context.
e.g.
type Service struct {
ctx context.Context
cancel func()
}
func NewService() *Service {
s := &Service{}
s.ctx, s.cancel = context.WithCancel(context.Background())
return s
}There was a problem hiding this comment.
Good shout – I'll alter the Open method to take a context.Context
Configuration of the check interval is available via ``` --storage-retention-check-interval ``` Closes #19309
* Pass context.Context to Service.Open * Remove redundant comments * Bind to retention.Config configuration to be consistent with 1.x
stuartcarnie
force-pushed
the
sgc/issue/19309
branch
from
84f19f4 to
027143a
Compare
benbjohnson
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19309
This PR introduces the retention policy enforcement service from InfluxDB 1.x. This service is responsible for evaluating retention policy rules and deleted shards which fall outside the time bounds.
In addition, configuration of the check interval is available via
Finally, due to the introduction of the retention policy service, a number of types and interfaces were removed to keep the static checker happy, as they were no longer used.