feat: allow a metadata key to be required for a query to be logged #19200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffcm
suggested changes
Aug 4, 2020
adrian-thurston
force-pushed
the
feat/query-log-conn-err
branch
from
a6bff75 to
ebcc6b7
Compare
Can specify that a key must be present in the query response metadata before LoggingProxyQueryService logs the query. Will use this in gateway to only log the query when the connection to queryd fails.
adrian-thurston
force-pushed
the
feat/query-log-conn-err
branch
from
ebcc6b7 to
6488371
Compare
No problem, there was already some nice testing infrastructure present. Made it easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can specify that a key must be present in the query response metadata before
LoggingProxyQueryService logs the query. Will use this in gateway to only log
the query when the connection to queryd fails.
https://github.com/influxdata/idpe/issues/8013