Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed overflow issue on scrollbar list #17010

Merged
merged 5 commits into from
Feb 25, 2020
Merged

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Feb 25, 2020

Closes #16827

Problem

Resource lists were overflowing past the confines of the parent container

Solution

Updated the CSS to hide the overflow and updated the dimension of the inner div to allow for scrolling

  • CHANGELOG.md updated with a link to the PR (not the Issue)

scrollbar_regression

@asalem1 asalem1 requested a review from alexpaxton February 25, 2020 21:29
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booooom

@asalem1 asalem1 merged commit c225be8 into master Feb 25, 2020
@asalem1 asalem1 deleted the checklist-scroll-bug branch February 25, 2020 23:43
jacobmarble pushed a commit that referenced this pull request Mar 12, 2020
fix(ui): fixed overflow issue on scrollbar list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checks list isn't scrollable
2 participants