fix: query builder groups on columns, not tag values #16992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
changed the title
hoorayimhelping
force-pushed
the
bs_make_query_builder_actually_usable
branch
from
55bd7d0 to
98750c4
Compare
hoorayimhelping
commented
Feb 24, 2020
| ...activeQueryTags[2].values, | ||
| ]) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
this test was testing the wrong thing
There was a problem hiding this comment.
can we test the right thing?
There was a problem hiding this comment.
can we test the right thing?
@121watts only cause you asked https://github.com/influxdata/influxdb/pull/16992/files#diff-c432c510f4c140978dbe371ff3e9142dR93
hoorayimhelping
force-pushed
the
bs_make_query_builder_actually_usable
branch
from
98750c4 to
25b8387
Compare
121watts
approved these changes
Feb 24, 2020
| @@ -49,6 +48,9 @@ import { | |||
|
|
|||
| const SEARCH_DEBOUNCE_MS = 500 | |||
|
|
|||
| // We don't show these columns in results but they're able to be grouped on | |||
There was a problem hiding this comment.
This is not always true. There are scenarios where a _start and _stop are not not columns in a query response.
There was a problem hiding this comment.
Russ mentioned that, but it seems like in the context of query builder, it's safe to assume we can group on those columns? I'll change the comment
| ...activeQueryTags[2].values, | ||
| ]) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
can we test the right thing?
hoorayimhelping
force-pushed
the
bs_make_query_builder_actually_usable
branch
2 times, most recently
from
8fbf745 to
3a31f0a
Compare
hoorayimhelping
force-pushed
the
bs_make_query_builder_actually_usable
branch
from
3a31f0a to
215962a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16783
A picture is worth a thousand words, so here:
WRONG:
Right:
