chore(kv): refactor kv.Entity to provide interface for PK and unique keys #16379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
kv/entity_fixer_upper
branch
2 times, most recently
from
6699df3 to
386ae12
Compare
jsteenb2
force-pushed
the
kv/entity_fixer_upper
branch
from
386ae12 to
44125eb
Compare
jsteenb2
force-pushed
the
kv/entity_fixer_upper
branch
2 times, most recently
from
04e8ab2 to
ee5de4a
Compare
4 tasks
jsteenb2
force-pushed
the
kv/entity_fixer_upper
branch
from
ee5de4a to
033fe6c
Compare
kelwang
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to make the new
kv.Entitymore generic so that it can be used in more broad applications.