Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update wording and remove name editing in checks page #15884

Merged
merged 1 commit into from
Nov 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/alerting/components/CheckAlertingButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const CheckAlertingButton: FunctionComponent<Props> = ({
active={activeTab === 'queries'}
onClick={handleClick('queries')}
>
1. Query
1. Define Query
</Radio.Button>

<Radio.Button
Expand All @@ -48,7 +48,7 @@ const CheckAlertingButton: FunctionComponent<Props> = ({
active={activeTab === 'alerting'}
onClick={handleClick('alerting')}
>
2. Check
2. Configure Check
</Radio.Button>
</Radio>
)
Expand Down
17 changes: 0 additions & 17 deletions ui/src/alerting/components/builder/CheckMetaCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {connect} from 'react-redux'

// Components
import {Form, ComponentSize, ComponentColor, Grid} from '@influxdata/clockface'
import {Input} from '@influxdata/clockface'
import DashedButton from 'src/shared/components/dashed_button/DashedButton'
import CheckTagRow from 'src/alerting/components/builder/CheckTagRow'
import DurationSelector from 'src/shared/components/DurationSelector'
Expand Down Expand Up @@ -37,12 +36,6 @@ const CheckMetaCard: FC<Props> = ({
onUpdateTimeMachineCheck,
onSelectCheckEvery,
}) => {
const handleChange = (
e: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>
) => {
onUpdateTimeMachineCheck({[e.target.name]: e.target.value})
}

const addTagsRow = () => {
const tags = check.tags || []
onUpdateTimeMachineCheck({tags: [...tags, {key: '', value: ''}]})
Expand All @@ -67,16 +60,6 @@ const CheckMetaCard: FC<Props> = ({
>
<BuilderCard.Header title="Properties" />
<BuilderCard.Body addPadding={true} autoHideScrollbars={true}>
<Form.Element label="Name">
<Input
autoFocus={true}
name="name"
onChange={handleChange}
placeholder="Name this check"
size={ComponentSize.Small}
value={check.name}
/>
</Form.Element>
<Grid>
<Grid.Row>
<Grid.Column widthSM={6}>
Expand Down