Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): update appearance of tables #15783

Merged
merged 5 commits into from
Nov 6, 2019
Merged

refactor(ui): update appearance of tables #15783

merged 5 commits into from
Nov 6, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Nov 6, 2019 •
edited
Loading

  • Modify table cells and raw data table to match "dark cell" aesthetic
  • Modify variables control bar to match "dark cell" aesthetic
  • Add link to docs in empty variables control bar
  • Replace FancyScrollbars with DapperScrollbars in table cell sidebar

Screen Shot 2019-11-06 at 10 43 54 AM

Screen Shot 2019-11-06 at 12 34 04 PM

Screen Shot 2019-11-06 at 12 33 49 PM

Screen Shot 2019-11-06 at 12 34 39 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team November 6, 2019 17:35
@ghost ghost requested review from 121watts and drdelambre and removed request for a team November 6, 2019 17:36
drdelambre
drdelambre approved these changes Nov 6, 2019
View reviewed changes
ui/src/dashboards/components/variablesControlBar/VariablesControlBar.tsx Outdated
@@ -95,7 +95,8 @@ class VariablesControlBar extends PureComponent<Props, State> {
className="variables-control-bar--empty"
>
<EmptyState.Text>
To see variable controls here, use a variable in a cell query
This dashboard doesn't have any cells with defined variables. {' '}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS SO MUCH NICER!

@alexpaxton alexpaxton merged commit 9e34e39 into master Nov 6, 2019
@alexpaxton alexpaxton deleted the misc-dash-polish branch November 6, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexpaxton @drdelambre @121watts