fix: cell errors #14168
Merged
fix: cell errors #14168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
force-pushed
the
fix/cell-errors
branch
from
1837b31 to
2e6202b
Compare
chnn
approved these changes
Jun 20, 2019
| word-wrap: break-word; | ||
| width: calc(100% - #{$box-tooltip--caret-size * 2}); | ||
|
|
||
| pre { |
There was a problem hiding this comment.
I viewed the box tooltip as a generic container component that you could put anything inside. It seems like these additional .box-tooltip--contents styles belong on the child component. What do you think? Want to keep the box tooltip / composable.
|
|
||
| // If the width of the tooltip causes it to overflow left | ||
| // position it to the right of the trigger element | ||
| if (left < 0) { |
There was a problem hiding this comment.
nice. Think this makes the comment on line 36 out of date
| @@ -44,7 +62,7 @@ const BoxTooltip: FunctionComponent<Props> = ({triggerRect, children}) => { | |||
|
|
|||
| el.setAttribute( | |||
| 'style', | |||
| `visibility: visible; top: ${top}px; left: ${left}px;` | |||
| `visibility: visible; top: ${top}px; left: ${left}px; max-width: ${maxWidth}px;` | |||
There was a problem hiding this comment.
What if maxWidth isn't passed? Is setting this to undefinedpx ok?
There was a problem hiding this comment.
yeah that's probably fine, the browser will ignore it
| testID?: string | ||
| } | ||
|
|
||
| const EmptyGraphError: FunctionComponent<Props> = ({message, testID}) => { |
There was a problem hiding this comment.
totally minor but name it the same as the filename?
| </div> | ||
| </div> | ||
| ) | ||
| } |
mavarius
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After