fix(storage): Assume sorted StringIterators, and retain sorted order #13491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebo
approved these changes
Apr 18, 2019
stuartcarnie
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Looks good, @jacobmarble
Only change I'd recommend is switching to an embedded struct vs a pointer for stringIteratorHeap
jacobmarble
force-pushed
the
jgm-merged-sorted
branch
from
24a4e88 to
4e39160
Compare
OfTheDelmer
pushed a commit
that referenced
this pull request
Apr 19, 2019
…13491) * fix(storage): Assume sorted StringIterators, and retain sorted order * embed struct field * improve MergedStringIterator efficiency
stuartcarnie
pushed a commit
that referenced
this pull request
Apr 22, 2019
…13491) * fix(storage): Assume sorted StringIterators, and retain sorted order * embed struct field * improve MergedStringIterator efficiency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume that
StringIteratoralways returns values in order, then retain that order on merge. Cost islog(n)per call toMergedStringIterator.Next()wherenis the quantity of non-emptyStringIterators.Closes #13440