Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Create import overlay to import variables #12958

Merged
merged 1 commit into from
Mar 27, 2019
Merged

feat(ui): Create import overlay to import variables #12958

merged 1 commit into from
Mar 27, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Mar 27, 2019 •
edited
Loading

Closes #12884

Briefly describe your proposed changes:

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the feat/import-variables branch from 343ef54 to d4b3de6 Compare March 27, 2019 22:06
Palakp41
Palakp41 approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@Palakp41 Palakp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion, everything looks good!

@ischolten ischolten merged commit d7780e1 into master Mar 27, 2019
@ischolten ischolten deleted the feat/import-variables branch March 27, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakp41 Palakp41 Palakp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @Palakp41