Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkger enforce resource metadata.name field is dns compliant #17940

Closed
3 tasks done
jsteenb2 opened this issue May 2, 2020 · 0 comments · Fixed by #17941
Closed
3 tasks done

pkger enforce resource metadata.name field is dns compliant #17940

jsteenb2 opened this issue May 2, 2020 · 0 comments · Fixed by #17941
Labels
team/user-tools

Comments

@jsteenb2
Copy link
Contributor

jsteenb2 commented May 2, 2020 •
edited
Loading

Pkger resources metadata.name field should be DNS compliant

  • resource names must be between 3 and 63 characters long.
  • resource names can consist only of lowercase letters, numbers, dots (.), and hyphens (-).
  • resource names must not be formatted as an IP address (for example, 192.168.5.4).

useful link from std lib:
isDomainName: https://golang.org/src/net/dnsclient.go
jsteenb2 added a commit that referenced this issue May 3, 2020
@jsteenb2
feat(pkger): enforce metadata.name dns name compliance
9af4d50 
closes: #17940
@jsteenb2 jsteenb2 mentioned this issue May 3, 2020
Merged
4 tasks
jsteenb2 added a commit that referenced this issue May 3, 2020
@jsteenb2
feat(pkger): enforce metadata.name dns name compliance
e4299ce 
closes: #17940
jsteenb2 added a commit that referenced this issue May 4, 2020
@jsteenb2
feat(pkger): enforce metadata.name dns name compliance
3dc3440 
this PR includes a lot of small changes to names in existing test pkgs.
the tests are updated to follow suit.

closes: #17940
jsteenb2 added a commit that referenced this issue May 4, 2020
@jsteenb2
feat(pkger): enforce metadata.name dns name compliance
784b222 
this PR includes a lot of small changes to names in existing test pkgs.
the tests are updated to follow suit.

closes: #17940
ethanyzhang pushed a commit that referenced this issue May 5, 2020
@jsteenb2 @ethanyzhang
feat(pkger): enforce metadata.name dns name compliance
1d027cf 
this PR includes a lot of small changes to names in existing test pkgs.
the tests are updated to follow suit.

closes: #17940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/user-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pkger): enforce metadata.name dns name compliance influxdata/influxdb
1 participant
@jsteenb2