Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add influxdb errors to pkger service error handling #16313

Closed
jsteenb2 opened this issue Dec 21, 2019 · 0 comments · Fixed by #16314
Closed

Add influxdb errors to pkger service error handling #16313

jsteenb2 opened this issue Dec 21, 2019 · 0 comments · Fixed by #16314
Assignees
@jsteenb2
Labels
team/user-tools

Comments

@jsteenb2
Copy link
Contributor

right now the pkger service isn't returning great errors outside the parser errors. This issue is to update the service errors to be uniform and utilize the influxdb.Error type to provide errors across functional boundaries.
@jsteenb2 jsteenb2 self-assigned this Dec 21, 2019
jsteenb2 added a commit that referenced this issue Dec 22, 2019
@jsteenb2
chore(pkger): improve error handling in service
a106492 
this provides influxdb.Errors whenever possible from the pker service layer.
the behavior that caused the error is somewhat implicated in the errro code.
it is not perfect but is a big step forward. using the http server/client to
run pkger stuff makes it abundantly clear the errors need to be communicated
better.

closes: #16313
@jsteenb2 jsteenb2 mentioned this issue Dec 22, 2019
Merged
3 tasks
jsteenb2 added a commit that referenced this issue Dec 23, 2019
@jsteenb2
chore(pkger): improve error handling in service
8c07810 
this provides influxdb.Errors whenever possible from the pker service layer.
the behavior that caused the error is somewhat implicated in the errro code.
it is not perfect but is a big step forward. using the http server/client to
run pkger stuff makes it abundantly clear the errors need to be communicated
better.

closes: #16313
jsteenb2 added a commit that referenced this issue Dec 23, 2019
@jsteenb2
chore(pkger): improve error handling in service
d2daac4 
this provides influxdb.Errors whenever possible from the pker service layer.
the behavior that caused the error is somewhat implicated in the errro code.
it is not perfect but is a big step forward. using the http server/client to
run pkger stuff makes it abundantly clear the errors need to be communicated
better.

closes: #16313
jsteenb2 added a commit that referenced this issue Dec 23, 2019
@jsteenb2
chore(pkger): improve error handling in service
aef32b0 
this provides influxdb.Errors whenever possible from the pker service layer.
the behavior that caused the error is somewhat implicated in the errro code.
it is not perfect but is a big step forward. using the http server/client to
run pkger stuff makes it abundantly clear the errors need to be communicated
better.

closes: #16313
alexpaxton pushed a commit that referenced this issue Jan 9, 2020
@jsteenb2 @alexpaxton
chore(pkger): improve error handling in service
dbacbe3 
this provides influxdb.Errors whenever possible from the pker service layer.
the behavior that caused the error is somewhat implicated in the errro code.
it is not perfect but is a big step forward. using the http server/client to
run pkger stuff makes it abundantly clear the errors need to be communicated
better.

closes: #16313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsteenb2 jsteenb2

Labels
team/user-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pkger): improve error handling in service influxdata/influxdb
1 participant
@jsteenb2