fix(ui): fixed dark lines in checks (#17651)

influxdata · Apr 7, 2020 · ffa48c5 · ffa48c5
1 parent 6854ead
commit ffa48c5
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 56 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 ### Bug Fixes
 
 1. [17612](https://github.com/influxdata/influxdb/pull/17612): Fix card size and layout jank in dashboards index view
+1. [17651](https://github.com/influxdata/influxdb/pull/17651): Fix check graph font and lines defaulting to black causing graph to be unreadable
 
 ### UI Improvements
 

diff --git a/http/swagger.yml b/http/swagger.yml
@@ -8872,7 +8872,7 @@ components:
           description: Colors define color encoding of data into a visualization
           type: array
           items:
-            type: string
+            $ref: "#/components/schemas/DashboardColor"
     Axes:
       description: The viewport for a View's visualizations
       type: object

diff --git a/ui/src/shared/components/CheckPlot.tsx b/ui/src/shared/components/CheckPlot.tsx
@@ -16,6 +16,7 @@ import {getFormatter, filterNoisyColumns} from 'src/shared/utils/vis'
 // Constants
 import {VIS_THEME} from 'src/shared/constants'
 import {INVALID_DATA_COPY} from 'src/shared/copy/cell'
+import {DEFAULT_LINE_COLORS} from 'src/shared/constants/graphColorPalettes'
 
 // Types
 import {
@@ -100,6 +101,11 @@ const CheckPlot: FunctionComponent<Props> = ({
 
   const yTicks = thresholdValues.length ? thresholdValues : null
 
+  const colorHexes =
+    colors && colors.length
+      ? colors.map(c => c.hex)
+      : DEFAULT_LINE_COLORS.map(c => c.hex)
+
   const config: Config = {
     ...VIS_THEME,
     table,
@@ -119,7 +125,7 @@ const CheckPlot: FunctionComponent<Props> = ({
         y: Y_COLUMN,
         fill: groupKey,
         interpolation: 'linear',
-        colors,
+        colors: colorHexes,
       },
       {
         type: 'custom',

diff --git a/ui/src/timeMachine/components/view_options/CheckOptions.tsx b/ui/src/timeMachine/components/view_options/CheckOptions.tsx
diff --git a/ui/src/timeMachine/components/view_options/OptionsSwitcher.tsx b/ui/src/timeMachine/components/view_options/OptionsSwitcher.tsx
@@ -9,7 +9,6 @@ import TableOptions from 'src/timeMachine/components/view_options/TableOptions'
 import HistogramOptions from 'src/timeMachine/components/view_options/HistogramOptions'
 import HeatmapOptions from 'src/timeMachine/components/view_options/HeatmapOptions'
 import ScatterOptions from 'src/timeMachine/components/view_options/ScatterOptions'
-import CheckOptions from 'src/timeMachine/components/view_options/CheckOptions'
 
 // Types
 import {View, NewView} from 'src/types'
@@ -44,8 +43,6 @@ class OptionsSwitcher extends PureComponent<Props> {
         return <HeatmapOptions {...view.properties} />
       case 'scatter':
         return <ScatterOptions {...view.properties} />
-      case 'check':
-        return <CheckOptions properties={view.properties} />
       default:
         return <div />
     }

diff --git a/ui/src/views/helpers/index.ts b/ui/src/views/helpers/index.ts
@@ -281,7 +281,7 @@ const NEW_VIEW_CREATORS = {
           },
         },
       ],
-      colors: NINETEEN_EIGHTY_FOUR,
+      colors: DEFAULT_LINE_COLORS as Color[],
     },
   }),
   deadman: (): NewView<CheckViewProperties> => ({
@@ -308,7 +308,7 @@ const NEW_VIEW_CREATORS = {
           },
         },
       ],
-      colors: NINETEEN_EIGHTY_FOUR,
+      colors: DEFAULT_LINE_COLORS as Color[],
     },
   }),
   custom: (): NewView<TableViewProperties> => ({