Skip to content

Commit

Permalink
fix: use valid flux in pkger test templates (#19465)
Browse files Browse the repository at this point in the history
  • Loading branch information
glinton authored Oct 19, 2020
1 parent 2b828c5 commit b63bcb4
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 6 deletions.
11 changes: 9 additions & 2 deletions pkger/parser_models.go
Original file line number Diff line number Diff line change
Expand Up @@ -2346,7 +2346,11 @@ func astDurationFromIface(v interface{}) *ast.DurationLiteral {
}
s = d.String()
}
dur, _ := parser.ParseSignedDuration(s)

dur, err := parser.ParseSignedDuration(s)
if err != nil {
dur, _ = parser.ParseSignedDuration("-0m")
}
return dur
}

Expand Down Expand Up @@ -2387,7 +2391,10 @@ func astTimeFromIface(v interface{}) *ast.DateTimeLiteral {
return nil
}

t, _ := parser.ParseTime(s)
t, err := parser.ParseTime(s)
if err != nil {
return ast.DateTimeLiteralFromValue(time.Now())
}
return t
}

Expand Down
4 changes: 2 additions & 2 deletions pkger/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2433,7 +2433,7 @@ spec:
}
from(bucket: params.bucket)
|> range(start: params.start, end: params.stop)
|> range(start: params.start, stop: params.stop)
|> filter(fn: (r) =>
(r._measurement == "processes"))
|> filter(fn: (r) =>
Expand Down Expand Up @@ -3433,7 +3433,7 @@ spec:
}
from(bucket: params.bucket)
|> range(start: params.start, end: params.stop)
|> range(start: params.start, stop: params.stop)
|> filter(fn: (r) =>
(r._measurement == "processes"))
|> filter(fn: (r) =>
Expand Down
2 changes: 1 addition & 1 deletion pkger/testdata/dashboard_params.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
}
from(bucket: params.bucket)
|> range(start: params.start, end: params.stop)
|> range(start: params.start, stop: params.stop)
|> filter(fn: (r) => r._measurement == "processes")
|> filter(fn: (r) => r.floater == params.floatVal)
|> filter(fn: (r) => r._value > params.minVal)
Expand Down
2 changes: 1 addition & 1 deletion pkger/testdata/tasks_params.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
}
from(bucket: params.bucket)
|> range(start: params.start, end: params.stop)
|> range(start: params.start, stop: params.stop)
|> filter(fn: (r) => r._measurement == "processes")
|> filter(fn: (r) => r.floater == params.floatVal)
|> filter(fn: (r) => r._value > params.minVal)
Expand Down

0 comments on commit b63bcb4

Please sign in to comment.