Merge pull request #20151 from influxdata/dm-debug-log-no-body-19978

fix(http): don't log bodies of V1 write requests
influxdata · Nov 23, 2020 · aa0defe · aa0defe
2 parents cae1417 + 00a91ad
commit aa0defe
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ want to use the default.
 
 1. [20110](https://github.com/influxdata/influxdb/pull/20110): Use V2 directory for default V2 config path in `influxd upgrade`.
 1. [20137](https://github.com/influxdata/influxdb/pull/20137): Fix panic when writing a point with 100 tags. Thanks @foobar!
+1. [20151](https://github.com/influxdata/influxdb/pull/20151): Don't log bodies of V1 write requests.
 
 ## v2.0.2 [2020-11-19]
 

diff --git a/http/middleware.go b/http/middleware.go
@@ -140,6 +140,7 @@ var blacklistEndpoints = map[string]isValidMethodFn{
 	usersPasswordPath:                ignoreMethod(),
 	"/api/v2/packages/apply":         ignoreMethod(),
 	prefixWrite:                      ignoreMethod("POST"),
+	"/write":                         ignoreMethod("POST"),
 	organizationsIDSecretsPath:       ignoreMethod("PATCH"),
 	organizationsIDSecretsDeletePath: ignoreMethod("POST"),
 	prefixSetup:                      ignoreMethod("POST"),

diff --git a/http/middleware_test.go b/http/middleware_test.go
@@ -232,6 +232,11 @@ func TestLoggingMW(t *testing.T) {
 				method: "POST",
 				path:   "/api/v2/write",
 			},
+			{
+				name:   "legacy write path",
+				method: "POST",
+				path:   "/write",
+			},
 			{
 				name:   "orgs id secrets path",
 				method: "PATCH",