fix(tasks): add content length check to decode force run request

influxdata · Jan 8, 2020 · 0dd7b31 · 0dd7b31
1 parent 128b9ee
commit 0dd7b31
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -49,6 +49,7 @@
 1. [16435](https://github.com/influxdata/influxdb/pull/16435): Time labels are no longer squished to the left
 1. [16427](https://github.com/influxdata/influxdb/pull/16427): Fixed underlying issue with disappearing queries made in Advanced Mode
 1. [16439](https://github.com/influxdata/influxdb/pull/16439): Prevent negative zero and allow zero to have decimal places
+1. [16458](https://github.com/influxdata/influxdb/pull/16458): Fix EOF error when manually running tasks from the Task Page.
 
 ### UI Improvements
 1. [16444](https://github.com/influxdata/influxdb/pull/16444): Add honeybadger reporting to create checks

diff --git a/http/task_service.go b/http/task_service.go
@@ -1085,8 +1085,11 @@ func decodeForceRunRequest(ctx context.Context, r *http.Request) (forceRunReques
 	var req struct {
 		ScheduledFor string `json:"scheduledFor"`
 	}
-	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
-		return forceRunRequest{}, err
+
+	if r.ContentLength != 0 && r.ContentLength < 1000 { // prevent attempts to use up memory since r.Body should include at most one item (RunManually)
+		if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+			return forceRunRequest{}, err
+		}
 	}
 
 	var t time.Time