Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip of verifying SSL certificate could be configured via config file or environment properties #143

Merged
merged 1 commit into from
Aug 11, 2020
Merged

feat: skip of verifying SSL certificate could be configured via config file or environment properties #143

merged 1 commit into from
Aug 11, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 10, 2020

Closes #142

Proposed Changes

The verify_ssl could be configured via config file or environment properties.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar added the enhancement New feature or request label Aug 10, 2020
@bednar bednar requested review from rolincova and rhajek August 10, 2020 08:10
@bednar bednar mentioned this pull request Aug 10, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #143 into master will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   88.89%   88.93%   +0.03%     
==========================================
  Files          23       23              
  Lines        1864     1870       +6     
==========================================
+ Hits         1657     1663       +6     
  Misses        207      207
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 98.37% <85.71%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d1b0b...362cbf7. Read the comment docs.

@bednar bednar merged commit 7d5f2c2 into master Aug 11, 2020
@bednar bednar deleted the feat/configuration-from-file branch August 11, 2020 12:45
@bednar bednar added this to the 1.10.0 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

@rolincova rolincova rolincova approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Set InfluxDBClient verify_ssl parameter via config file
4 participants
@bednar @codecov-commenter @rhajek @rolincova